Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corepack manager use pnpm failed #2965

Merged
merged 17 commits into from
Feb 6, 2025

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Feb 5, 2025

背景

发现CI中corepack enable pnpm失败

原因

nodejs/corepack#612 https://community.plone.org/t/corepack-problems-specially-in-ci/20597
近期在corepack和pnpm社区出现了大量相关issues

解决方法

对比社区各种方法暂时没有发现较好的持久性结论,暂时不通过corepack去use pnpm

Summary by CodeRabbit

  • Chores
    • 更新自动化流程配置,确保构建、测试和发布流程使用特定版本的包管理工具,从而提升整体流程的一致性与稳定性。
    • 对部分配置文件进行了轻微的格式优化。

Copy link

coderabbitai bot commented Feb 5, 2025

Warning

Rate limit exceeded

@Alex-huxiyang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e123b6 and c90c38d.

📒 Files selected for processing (6)
  • .github/workflows/ci.yml (4 hunks)
  • .github/workflows/cypress.yml (1 hunks)
  • .github/workflows/realease-tag.yml (1 hunks)
  • .github/workflows/sync-h5.yml (1 hunks)
  • .github/workflows/sync-migrate.yml (1 hunks)
  • .github/workflows/sync-taro.yml (1 hunks)

Walkthrough

本次PR修改了多个GitHub Actions工作流文件中pnpm的安装命令。原先使用 corepack enable pnpm 的方式已被替换为 corepack enablecorepack prepare [email protected] --activate,指定了pnpm的版本。其他流程保持不变,仅在ci.yml文件末尾进行了格式微调(添加了换行)。

Changes

文件路径 变更摘要
.github/workflows/ci.yml, .github/workflows/cypress.yml, .github/workflows/realease-tag.yml,
.github/workflows/sync-h5.yml, .github/workflows/sync-migrate.yml, .github/workflows/sync-taro.yml
corepack enable pnpm 替换为 corepack enablecorepack prepare [email protected] --activate 更新了pnpm安装方式;ci.yml 增加末尾换行。

Possibly related PRs

Suggested reviewers

  • oasis-cloud

Poem

我是一只快乐的小兔子,
蹦跳在代码的林间,
pnpm新命令闪耀星光,
版本指定轻轻敲响,
GitHub之路充满奇幻!
快与我一起跃向明天!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x Target branch 3.x label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.74%. Comparing base (95c21a7) to head (c90c38d).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #2965   +/-   ##
==========================================
  Coverage      85.74%   85.74%           
==========================================
  Files            277      277           
  Lines          18110    18110           
  Branches        2745     2745           
==========================================
  Hits           15528    15528           
  Misses          2577     2577           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoyatong
Copy link
Collaborator

目标还是使用 corepack。先合并等升级。

@xiaoyatong xiaoyatong merged commit c2b21ba into jdf2e:feat_v3.x Feb 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Target branch 3.x size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants